review of 14649

[Tom Kramer]

Len Slovensky wrote:

> I have been reviewing the EXPRESS schemas for part 11 and part 10.  I found
> a few compile errors and other problems, none of which are major technical,
> but I believe need to be fixed.  Attached are the schemas with my proposed
> changes.  I have marked all changes I made with my initials - LWS.

> Regards,
> Len Slovensky

I also have been reviewing (and implementing) the EXPRESS schemas for
part 11 and part 10. I had independently fixed problems that prevented
compiling the schemas (using STEP Tools expfront). Here are my
comments on Len's proposed changes.

Tom K.

P.S. I also have many comments on the text of Parts 10, 11, and 111.
These are not included here.

Len's Proposed Changes to Part 10
---------------------------------

1. Add reference to milling_technology. - AGREE
2. Add reference to oriented_surface. - AGREE
   An alternate way to fix this is to remove the WHERE rule from face_surface,
   since that is the only place oriented_surface is used.
3. Define poly_loop. - AGREE
   An alternate way to fix this is to remove the mixed_loop_type_set function,
   since that is the only place poly_loop is used.
4. Define founded_item. - AGREE
   An alternate way to fix this is to remove the using_items function,
   since that is the only place founded_item is used.
5. Define parametric_representation_context. - AGREE
   An alternate way to fix this is to remove the WHERE rule from
   definitional_representation, since that is the only place
   parametric_representation_context is used.
6. Replace REPRESENTATION_SCHEMA.REPRESENTATION.ITEMS with
   MACHINING_SCHEMA.REPRESENTATION.ITEMS. - AGREE
7. Replace MILLING_SCHEMA.REPRESENTATION.ITEMS with
   MACHINING_SCHEMA.REPRESENTATION.ITEMS in two places. - AGREE
8. Replace loop_slot_end_type with MACHINING_SCHEMA.LOOP_SLOT_END_TYPE
   in WHERE rule for slot. - AGREE
9. Capitalize machining_schema.round_hole in WHERE rules for counterbore_hole.
   and countersunk_hole. - AGREE
10. Remove WHERE rule on geometric_representation_item_3d - AGREE
   The rule does not compile even when CONFIG_CONTROL_DESIGN is replaced
   with MACHINING_SCHEMA.
   
Additional Proposed Changes to Part 10
--------------------------------------

1. In the WHERE rules for trimmed_curve, replace parameter_value with
   MACHINING_SCHEMA.PARAMETER_VALUE.
   There are almost certainly also two typographical errors in
   WHERE rules WR1 and WR2, since each rule repeats the same line
   twice. On the second line of WR1, trim_1[1] should be trim_1[2].
   On the second line of WR2, trim_2[1] should be trim_2[2].

2. In the entity workpiece_probing, the line that reads
   "direction:          direction;" should be replaced with
   "its_direction:      direction;".
   Using the same name for the attribute and its value type confused
   my compiler and will probably confuse other compilers.

3. AIC_TOPOLOGICALLY_BOUNDED_SURFACE is not defined or referenced
   anywhere, but is used repeatedly in WHERE rules. Either it should
   be defined or referenced, or the rules should be removed.

4. AIC_ADVANCED_BREP is not defined or referenced
   anywhere, but is used repeatedly in WHERE rules. Either it should
   be defined or referenced, or the rules should be removed.

Additional Useful Changes to Part 10
------------------------------------

1. Change the name of the entity "address". The C++ compiler I use would
not compile the C++ code generated by the STEP Tools EXPRESS compiler
until I changed the name. Apparently "address" is a reserved word of the
compiler. I changed the spelling to "adres", and then the compiler was
happy.


Len's Proposed Changes to Part 11
---------------------------------

1. Add machining_operation and nc_function to the "REFERENCE FROM
   machining_schema" section. - AGREE

2. Remove machining_strategy from the "REFERENCE FROM machining_schema"
   section. - AGREE

3. Add a blank in the middle of OPTIONALleft_or_right (which
   occurs twice). - AGREE

4. Put a semicolon at the end of WR2 of bottom_and_side_rough_milling.
   - AGREE

5. Put "END_ENTITY;" at the end of the definition of reaming. - This
   was not missing in my copy of the schema.


Additional Proposed Changes to Part 11
--------------------------------------

None.

Additional Useful Changes to Part 11
------------------------------------

1. In the definition of three_axes_tilted_tool, change "tool_direction"
to "its_tool_direction". Since tool_direction is the name of an entity,
using it as the name of an attribute will confuse compilers.

2. Change the spelling of the "explicit" entity. My C++ compiler was
confused by it. I changed the spelling to "exxplicit", and that made
the compiler happy.